Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pushbullet Adapter #43

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Sumitmaithani
Copy link

@Sumitmaithani Sumitmaithani commented Oct 7, 2023

What does this PR do?

Adds a new Push Adapter for sending push notification via Pushbullet.

Test Plan

  • SignIn and Create a new Application on Pushbullet
  • Add the following environment variables
  • PUSHBULLET_API_KEY: < API_KEY >
  • Run test against tests/e2e/Push/PushBulletTest.php

Related PRs and Issues

Closes #6397

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90 stnguyen90 self-requested a review October 12, 2023 15:57
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Please also make sure to:

  1. to run the formatter to fix the lint errors
  2. attach a screenshot of successful tests

src/Utopia/Messaging/Adapters/Push/PushBullet.php Outdated Show resolved Hide resolved
src/Utopia/Messaging/Adapters/Push/PushBullet.php Outdated Show resolved Hide resolved
@gewenyu99 gewenyu99 requested a review from stnguyen90 October 18, 2023 03:25
@gewenyu99
Copy link

@Sumitmaithani remember to re-request review next time!

@wess wess self-assigned this Oct 19, 2023
@stnguyen90 stnguyen90 changed the title Added PushBullet Adapter Added Pushbullet Adapter Oct 24, 2023
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more renames.

Please also attach a screenshot of successful tests.

tests/e2e/Push/PushBulletTest.php Outdated Show resolved Hide resolved
src/Utopia/Messaging/Adapters/Push/Pushbullet.php Outdated Show resolved Hide resolved
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more rename.

Please also attach a screenshot of successful tests.

src/Utopia/Messaging/Adapters/Push/Pushbullet.php Outdated Show resolved Hide resolved
@tessamero
Copy link

Hi @Sumitmaithani ,

Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.

We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.

Looking forward to your updates and thank you!

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@Sumitmaithani
Copy link
Author

@gewenyu99 sumitmaithani my discord username. Thanks

@gewenyu99
Copy link

Will reach out soon! Thanks for your patience, putting together a form for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💬 Improve Appwrite Messaging with Pushbullet Adapter
5 participants